[PATCH] D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution

Evgeny Stupachenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 16:09:13 PDT 2017


evstupac added a comment.

> I think that's contradictory -- you're saying that this change must be NFC; but it will avoid potential different results on different CPUs?

I don't have a case in my mind. However I agreed with Quentin, that floats "can introduce subtle difference from one target to other". That comes from https://reviews.llvm.org/D29826.

> In any case,  by "test" I meant testing the `FixedPoint64` class itself.

Ok. I'll add such.


Repository:
  rL LLVM

https://reviews.llvm.org/D30527





More information about the llvm-commits mailing list