[PATCH] D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution

Evgeny Stupachenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 14:57:52 PDT 2017


evstupac added a comment.

In https://reviews.llvm.org/D30527#760563, @sanjoy wrote:

> Drive by comment:  how about putting the `FixedPoint64` in ADT and adding one or two unit tests?


The class supports only unsigned values and misses some general operators. However I'm ok with adding it to ADT (and maybe supporting more later).
As for tests, this change should not change anything. The behavior should be the same. (float are replaced with fixed point to avoid potential different results on different CPUs).


Repository:
  rL LLVM

https://reviews.llvm.org/D30527





More information about the llvm-commits mailing list