[PATCH] D32048: ClamAV: Copy zlib into ClamAV benchmark

[Matthias Braun via llvm-commits]

> On Apr 17, 2017, at 8:03 PM, Gerolf Hoflehner <ghoflehner at apple.com> wrote:
> 
>> 
>> On Apr 13, 2017, at 2:00 PM, Matthias Braun via Phabricator via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> 
>> MatzeB created this revision.
>> Herald added subscribers: mgorny, mcrosier.
>> 
>> Avoid the external zlib dependency in ClamAV by copying zlib-1.2.11
>> source into the benchmark.
>> 
>> External dependencies are problematic in benchmarks because:
>> 
>> - They are not compiled with the same compiler/flags as the rest of the benchmarks.
>> - They are an additional burden to setup when running the test-suite. While zlib is a really popular and ubiquitous library it is still sometimes missing in cross-compilation settings.
>> - No external dependencies simplifies the buildsystem.
>> 
>> This will unfortunately increase the overal compilatime of ClamAV and may therefore disrupt the history of CTMark data.
> 
> By how much? 

On my machine with a default (x86_64, -O3) configuration using "ninja -j1" total buildtime of ClamAV goes from 13.2s to 15.1s (14% increase)

- Matthias

>> 
>> 
>> Repository:
>> rL LLVM
>> 
>> https://reviews.llvm.org/D32048
>> 
>> Files:
>> LICENSE.TXT
>> MultiSource/Applications/ClamAV/CMakeLists.txt
>> MultiSource/Applications/ClamAV/Makefile
>> MultiSource/Applications/ClamAV/zlib/crc32.h
>> MultiSource/Applications/ClamAV/zlib/deflate.h
>> MultiSource/Applications/ClamAV/zlib/gzguts.h
>> MultiSource/Applications/ClamAV/zlib/inffast.h
>> MultiSource/Applications/ClamAV/zlib/inffixed.h
>> MultiSource/Applications/ClamAV/zlib/inflate.h
>> MultiSource/Applications/ClamAV/zlib/inftrees.h
>> MultiSource/Applications/ClamAV/zlib/trees.h
>> MultiSource/Applications/ClamAV/zlib/zconf.h
>> MultiSource/Applications/ClamAV/zlib/zlib.h
>> MultiSource/Applications/ClamAV/zlib/zutil.h
>> MultiSource/Applications/ClamAV/zlib_adler32.c
>> MultiSource/Applications/ClamAV/zlib_compress.c
>> MultiSource/Applications/ClamAV/zlib_crc32.c
>> MultiSource/Applications/ClamAV/zlib_deflate.c
>> MultiSource/Applications/ClamAV/zlib_gzclose.c
>> MultiSource/Applications/ClamAV/zlib_gzlib.c
>> MultiSource/Applications/ClamAV/zlib_gzread.c
>> MultiSource/Applications/ClamAV/zlib_gzwrite.c
>> MultiSource/Applications/ClamAV/zlib_infback.c
>> MultiSource/Applications/ClamAV/zlib_inffast.c
>> MultiSource/Applications/ClamAV/zlib_inflate.c
>> MultiSource/Applications/ClamAV/zlib_inftrees.c
>> MultiSource/Applications/ClamAV/zlib_trees.c
>> MultiSource/Applications/ClamAV/zlib_uncompr.c
>> MultiSource/Applications/ClamAV/zlib_zutil.c
>> 
>> <D32048.95200.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170419/1876fb87/attachment.html>