<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 17, 2017, at 8:03 PM, Gerolf Hoflehner <<a href="mailto:ghoflehner@apple.com" class="">ghoflehner@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline">On Apr 13, 2017, at 2:00 PM, Matthias Braun via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><br class="">MatzeB created this revision.<br class="">Herald added subscribers: mgorny, mcrosier.<br class=""><br class="">Avoid the external zlib dependency in ClamAV by copying zlib-1.2.11<br class="">source into the benchmark.<br class=""><br class="">External dependencies are problematic in benchmarks because:<br class=""><br class="">- They are not compiled with the same compiler/flags as the rest of the benchmarks.<br class="">- They are an additional burden to setup when running the test-suite. While zlib is a really popular and ubiquitous library it is still sometimes missing in cross-compilation settings.<br class="">- No external dependencies simplifies the buildsystem.<br class=""><br class="">This will unfortunately increase the overal compilatime of ClamAV and may therefore disrupt the history of CTMark data.<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">By how much?<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>On my machine with a default (x86_64, -O3) configuration using "ninja -j1" total buildtime of ClamAV goes from 13.2s to 15.1s (14% increase)</div><div><br class=""></div><div>- Matthias</div><br class=""><blockquote type="cite" class=""><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class=""><br class="">Repository:<br class="">rL LLVM<br class=""><br class=""><a href="https://reviews.llvm.org/D32048" class="">https://reviews.llvm.org/D32048</a><br class=""><br class="">Files:<br class="">LICENSE.TXT<br class="">MultiSource/Applications/ClamAV/CMakeLists.txt<br class="">MultiSource/Applications/ClamAV/Makefile<br class="">MultiSource/Applications/ClamAV/zlib/crc32.h<br class="">MultiSource/Applications/ClamAV/zlib/deflate.h<br class="">MultiSource/Applications/ClamAV/zlib/gzguts.h<br class="">MultiSource/Applications/ClamAV/zlib/inffast.h<br class="">MultiSource/Applications/ClamAV/zlib/inffixed.h<br class="">MultiSource/Applications/ClamAV/zlib/inflate.h<br class="">MultiSource/Applications/ClamAV/zlib/inftrees.h<br class="">MultiSource/Applications/ClamAV/zlib/trees.h<br class="">MultiSource/Applications/ClamAV/zlib/zconf.h<br class="">MultiSource/Applications/ClamAV/zlib/zlib.h<br class="">MultiSource/Applications/ClamAV/zlib/zutil.h<br class="">MultiSource/Applications/ClamAV/zlib_adler32.c<br class="">MultiSource/Applications/ClamAV/zlib_compress.c<br class="">MultiSource/Applications/ClamAV/zlib_crc32.c<br class="">MultiSource/Applications/ClamAV/zlib_deflate.c<br class="">MultiSource/Applications/ClamAV/zlib_gzclose.c<br class="">MultiSource/Applications/ClamAV/zlib_gzlib.c<br class="">MultiSource/Applications/ClamAV/zlib_gzread.c<br class="">MultiSource/Applications/ClamAV/zlib_gzwrite.c<br class="">MultiSource/Applications/ClamAV/zlib_infback.c<br class="">MultiSource/Applications/ClamAV/zlib_inffast.c<br class="">MultiSource/Applications/ClamAV/zlib_inflate.c<br class="">MultiSource/Applications/ClamAV/zlib_inftrees.c<br class="">MultiSource/Applications/ClamAV/zlib_trees.c<br class="">MultiSource/Applications/ClamAV/zlib_uncompr.c<br class="">MultiSource/Applications/ClamAV/zlib_zutil.c<br class=""><br class=""><D32048.95200.patch>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></blockquote></div></blockquote></div><br class=""></body></html>