[PATCH] D32048: ClamAV: Copy zlib into ClamAV benchmark

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 14:36:45 PDT 2017


MatzeB added a comment.

In https://reviews.llvm.org/D32048#728990, @kristof.beyls wrote:

> On removing this from the benchmarking_only set: I don't think I've seen clamav be a test that's so noisy that the current methods in LNT to deal with noisy programs can't handle it.
>  But I also don't remember any performance delta that only clamav flagged up. In summary, I'd keep clamav in the benchmarking set, but also don't feel strongly about it being removed if that was a good for others.


I personally filter all benchmarks with a runtime shorter than 0.6s (`test-suite/util/compare.py --filter-short`) so I ignore ClamAV for performance measurements anyway. I am happy to leave it in the benchmarking set.


Repository:
  rL LLVM

https://reviews.llvm.org/D32048





More information about the llvm-commits mailing list