[PATCH] D29489: Optimize SETCC + VSEL of incompatible or illegal types

Wed Mar 15 12:35:50 PDT 2017

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

Please commit the new SystemZ tests separately from the code changes, so the commit shows how the generated code changes.

Otherwise LGTM.

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2880
+// a SETCC or a previously handled SETCC by convertMask().
+static inline bool isSETCCorConvertedSETCC(SDValue N) {
+  if (N.getOpcode() == ISD::EXTRACT_SUBVECTOR)
----------------
Needs to be #ifndef NDEBUG to avoid warnings in Release mode.

================
Comment at: utils/update_llc_test_checks.py:74
+    r'[ \t]+.cfi_startproc\n'
+    r'# BB#0:\n'
+    r'(?P<body>.*?)\n'
----------------
You probably want to keep the BB#0 comment; that lets you verify that the first instruction in the function is actually the one you expect.

================
Comment at: utils/update_llc_test_checks.py:123
+def scrub_asm_systemz(asm):
+  print "xxxx"
+  print >>sys.stderr, asm
----------------
?

https://reviews.llvm.org/D29489