[PATCH] D29489: Optimize SETCC + VSEL of incompatible or illegal types

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 01:16:14 PDT 2017


jonpa updated this revision to Diff 91976.
jonpa added a comment.

Commited as r297930.

Thanks for review!

Just to make sure: I actually asked during review if the SplitVSETCC() function I copied into LegalizeTypesGeneric.cpp from DAGCombiner should become a class member instead somewhere. Did we miss that? I wasn't sure where the best place would be for it.

@Uli: Do the new SystemZ tests and the script update look fine to you?


https://reviews.llvm.org/D29489

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  lib/CodeGen/SelectionDAG/LegalizeTypes.h
  lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp
  lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  test/CodeGen/ARM/vuzp.ll
  test/CodeGen/NVPTX/f16x2-instructions.ll
  test/CodeGen/SystemZ/vec-cmp-cmp-logic-select.ll
  test/CodeGen/SystemZ/vec-cmpsel.ll
  test/CodeGen/X86/2011-10-19-widen_vselect.ll
  test/CodeGen/X86/2011-10-21-widen-cmp.ll
  test/CodeGen/X86/psubus.ll
  test/CodeGen/X86/vselect-pcmp.ll
  utils/update_llc_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29489.91976.patch
Type: text/x-patch
Size: 382010 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170316/5b1872b2/attachment-0001.bin>


More information about the llvm-commits mailing list