[PATCH] D29609: [dsymutil] Follow dependencies during ODR uniquing

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

more inline comments.



================
Comment at: test/tools/dsymutil/X86/odr-fwd-declaration.cpp:8
+// RUN: llvm-dsymutil -f -oso-prepend-path=%p/../Inputs/odr-fwd-declaration -y %p/dummy-debug-map.map -o - | llvm-dwarfdump -debug-dump=info - | FileCheck %s
+
+#ifdef FILE1
----------------
Can you add a small comment about what is being tested here?


================
Comment at: tools/dsymutil/DwarfLinker.cpp:2197
+                        TF_ParentWalk | TF_Keep | TF_DependencyWalk | ODRFlag, 
+                        false);
+      AncestorIdx = CU.getInfo(AncestorIdx).ParentIdx;
----------------
either /*DIEODRSeen=*/false or use an enum.


Repository:
  rL LLVM

https://reviews.llvm.org/D29609