[PATCH] D29609: [dsymutil] Follow dependencies during ODR uniquing

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Thanks! Some stylistic comments inline.



================
Comment at: tools/dsymutil/DwarfLinker.cpp:2188
+  // DIEODRSeen can be true only if UseODR is true
+  assert(!DIEODRSeen || UseODR);
+  if (!DIEODRSeen) {
----------------
 assert((!DIEODRSeen || UseODR) && "DIEODRSeen should imply UseODR");


================
Comment at: tools/dsymutil/DwarfLinker.cpp:2290
+  
+  if (DIEODRSeen) {
+    assert(Flags & TF_DependencyWalk);
----------------
Add comment why we are exiting early here?


================
Comment at: tools/dsymutil/DwarfLinker.cpp:2291
+  if (DIEODRSeen) {
+    assert(Flags & TF_DependencyWalk);
+    return;
----------------
 assert((Flags & TF_DependencyWalk) && "some message");


Repository:
  rL LLVM

https://reviews.llvm.org/D29609