[PATCH] D29609: [dsymutil] Follow dependencies during ODR uniquing

[Frederic Riss via Phabricator via llvm-commits]

friss added a comment.

I'm still trying to wrap my head around the added logic, but in the meantime, one small suggestion:



================
Comment at: tools/dsymutil/DwarfLinker.cpp:2197
+                        TF_ParentWalk | TF_Keep | TF_DependencyWalk | ODRFlag, 
+                        false);
+      AncestorIdx = CU.getInfo(AncestorIdx).ParentIdx;
----------------
aprantl wrote:
> either /*DIEODRSeen=*/false or use an enum.
Is it possible to make it an additional TF_* enum and not add a function argument.


Repository:
  rL LLVM

https://reviews.llvm.org/D29609