ISD::ZERO_EXTEND / SIGN_EXTEND of sub-vectors

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 25 23:54:40 PST 2017


Hi Eli,

> Just because the input and output have legal width, doesn't 
> necessarily mean that they have the same width... many targets support 
> multiple vector widths.
>
> +    if (WidenVT.getSizeInBits() == InVT.getSizeInBits()){
>
> Whitespace.  Could also use a comment describing what sort of 
> input/output types you expect to handle here.
>
> Needs testcases.
>
> -Eli
>

Tried to formulate a good comment, and also included the tests I made 
for SystemZ. They check that only unpack instructions are used also in 
case of fewer elements than possible in a vector.

/Jonas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: WidenVecRes_Convert_w_tests.3.patch
Type: text/x-patch
Size: 5907 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170126/35bcf986/attachment.bin>


More information about the llvm-commits mailing list