ISD::ZERO_EXTEND / SIGN_EXTEND of sub-vectors

Friedman, Eli via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 10:11:14 PST 2017


On 1/25/2017 11:54 PM, Jonas Paulsson wrote:
> Hi Eli,
>
>> Just because the input and output have legal width, doesn't 
>> necessarily mean that they have the same width... many targets 
>> support multiple vector widths.
>>
>> +    if (WidenVT.getSizeInBits() == InVT.getSizeInBits()){
>>
>> Whitespace.  Could also use a comment describing what sort of 
>> input/output types you expect to handle here.
>>
>> Needs testcases.
>>
>> -Eli
>>
>
> Tried to formulate a good comment, and also included the tests I made 
> for SystemZ. They check that only unpack instructions are used also in 
> case of fewer elements than possible in a vector.

LGTM.

-Eli

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project



More information about the llvm-commits mailing list