[PATCH] D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections

[Peter Smith via Phabricator via llvm-commits]

peter.smith updated this revision to Diff 85420.
peter.smith edited the summary of this revision.
peter.smith added a comment.

Thanks for the comments. I've updated the diff.

At the moment I only really need addSyntheticLocal for Thunks, I thought it would be best to split that part from the first Thunk patch to get the interface to addSyntheticLocal before submitting the Thunk patch.

To test addSyntheticLocal I've made a patch to add mapping symbols to the PLT section. I've uploaded the whole thing with this patch. I think that this is a worthwhile improvement to the disassembly of the PLT section especially on GNU objdump.

I'm happy to abandon this review and roll in addSyntheticLocal to either the first Thunks patch. Or I'm happy to add the PLT mapping symbols if you'd prefer?


https://reviews.llvm.org/D28956

Files:
  ELF/SyntheticSections.cpp
  ELF/SyntheticSections.h
  ELF/Target.cpp
  ELF/Target.h
  ELF/Writer.cpp
  test/ELF/arm-gnu-ifunc-plt.s
  test/ELF/arm-gnu-ifunc.s
  test/ELF/arm-plt-reloc.s
  test/ELF/arm-thumb-interwork-shared.s
  test/ELF/arm-thumb-plt-reloc.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28956.85420.patch
Type: text/x-patch
Size: 17772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170123/795c04d5/attachment.bin>