[PATCH] D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

It looks like this patch does not contain all changes. You defined addSyntehticLocal but you are not using it...?



================
Comment at: ELF/SyntheticSections.cpp:292
+                                   InputSectionBase<ELFT> *Section) {
+  auto S = new (BAlloc) DefinedRegular<ELFT>(
+      Name, /*IsLocal*/ true, STV_DEFAULT, Type, Value, Size, Section, nullptr);
----------------
S -> *S


https://reviews.llvm.org/D28956