[PATCH] D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I think this patch would be useful per se, but I wonder if you emit more than $a or $d? I mean those symbols could include the original symbol names to which these PLT entries jump to at runtime. (But if it is too much or too weird, I'm OK with this patch.)



================
Comment at: ELF/Target.cpp:1738-1739
+  auto* IS = dyn_cast<InputSection<ELF32LE>>(ISD);
+  addSyntheticLocal(Saver.save("$a"), STT_NOTYPE, 0, 0, IS);
+  addSyntheticLocal(Saver.save("$d"), STT_NOTYPE, 16, 0, IS);
+}
----------------
Since string constants are not on the stack, I think you don't need to use Saver.


https://reviews.llvm.org/D28956