[PATCH] D28331: Improve PGO support for the new inliner

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 13:30:47 PST 2017


Thanks, will split them into separate patches and revisit this after they
get in.

On Tue, Jan 10, 2017 at 11:55 AM, David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added inline comments.
>
>
> ================
> Comment at: lib/Analysis/BlockFrequencyInfo.cpp:174
>
> +void BlockFrequencyInfo::setBlockFreqAndScale(
> +    const BasicBlock *AnchorBB, uint64_t Freq,
> ----------------
> can this one be split into a different patch (and with a unit test)?
>
>
> ================
> Comment at: lib/Analysis/ProfileSummaryInfo.cpp:147
>
> +bool ProfileSummaryInfo::isColdBB(const BasicBlock *B,
> +                                  BlockFrequencyInfo *BFI) {
> ----------------
> The following new APIs belong to a separate patch perhaps.
>
>
> https://reviews.llvm.org/D28331
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170110/5cacd6e1/attachment.html>


More information about the llvm-commits mailing list