<div dir="ltr">Thanks, will split them into separate patches and revisit this after they get in. </div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 10, 2017 at 11:55 AM, David Li via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">davidxl added inline comments.<br>
<br>
<br>
================<br>
</span>Comment at: lib/Analysis/<wbr>BlockFrequencyInfo.cpp:174<br>
<br>
+void BlockFrequencyInfo::<wbr>setBlockFreqAndScale(<br>
+    const BasicBlock *AnchorBB, uint64_t Freq,<br>
----------------<br>
can this one be split into a different patch (and with a unit test)?<br>
<br>
<br>
================<br>
Comment at: lib/Analysis/<wbr>ProfileSummaryInfo.cpp:147<br>
<br>
+bool ProfileSummaryInfo::isColdBB(<wbr>const BasicBlock *B,<br>
+                                  BlockFrequencyInfo *BFI) {<br>
----------------<br>
The following new APIs belong to a separate patch perhaps.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D28331" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D28331</a><br>
<br>
<br>
<br>
</blockquote></div><br></div>