[PATCH] D28331: Improve PGO support for the new inliner

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Analysis/BlockFrequencyInfo.cpp:174
 
+void BlockFrequencyInfo::setBlockFreqAndScale(
+    const BasicBlock *AnchorBB, uint64_t Freq,
----------------
can this one be split into a different patch (and with a unit test)?


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:147
 
+bool ProfileSummaryInfo::isColdBB(const BasicBlock *B,
+                                  BlockFrequencyInfo *BFI) {
----------------
The following new APIs belong to a separate patch perhaps.


https://reviews.llvm.org/D28331