[PATCH] D26671: Replace APFloatBase static fltSemantics data members with getter functions

Stephan Bergmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 08:30:40 PST 2016


sberg added a comment.

In https://reviews.llvm.org/D26671#613399, @zturner wrote:

> I think I may still be missing something.  In this patch, the accessor functions are not marked dllexport either, so how does this solve the problem?  I don't know how this `extract_symbols.py` works, does it have something to do with that?


Yes, the magic of selecting the symbols to export is done by extract_symbols.py.  (In short, most function symbols are exported, but no data symbols are, and the general understanding is that exported data symbols are unreliable with MSVC; see earlier comments for details.)


https://reviews.llvm.org/D26671





More information about the llvm-commits mailing list