[PATCH] D26671: Replace APFloatBase static fltSemantics data members with getter functions

Stephan Bergmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 08:27:47 PST 2016


sberg added a comment.

In https://reviews.llvm.org/D26671#613379, @mehdi_amini wrote:

> >> If you use svn, just apply all patches in a single commit; or you can use the git monorepo check-in script, see http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo .
> > 
> > But I can't upload such a single patch here in Phabricator, right?
>
> Sure you can!
>  (I updated the doc to mention the use of arc but you can also generate a textual diff if you prefer)


Which doc is that?  I've never felt the need to spend any amount of time in setting up and learning about arc, so I've only ever uploaded patches here via 'git diff -U999999'.  However, when I try that with this combined patch, Phabricator complains: "Uploaded file is too large: current limit is 8M. To adjust this limit change 'upload_max_filesize' in php.ini."


https://reviews.llvm.org/D26671





More information about the llvm-commits mailing list