[PATCH] D26671: Replace APFloatBase static fltSemantics data members with getter functions

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

I see.  My mild preference would be to remove as many C++isms as possible from exported interfaces.  So, in descending order of preference, this would be:

1. Make it return a `void*` instead of a `fltSemantics&`
2. Make these global free functions marked extern "C"

The first identifies at the contract level that `fltSemantics` is an opaque type and prevents any accidental forward declarations, and the second is just a nice-to-have for any exported function, especially when you're trying to do diagnostics and you don't want to deal with looking at mangled names.

Not going to block over either of these though.


https://reviews.llvm.org/D26671