[PATCH] D24699: [asan] Allow re-exec in instrumented unit tests on Darwin (fix unit tests on macOS <=10.10)

[Filipe Cabecinhas via llvm-commits]

No need to duplicate if you export the function or make it online anyway.

But having the comment makes sense. I'm ok with this.

Thank you,
Filipe

On Tue, 29 Nov 2016 at 21:53, Kuba (Brecka) Mracek via Phabricator <
reviews at reviews.llvm.org> wrote:

> kubabrecka added a comment.
>
> > If that's correct, then can we use the same trick as
> DyldNeedsEnvVariable for ReexecDisabled? Or am I making these two to be the
> same issue when they aren't?
>
> Do you mean to check `dyldVersionNumber`?  That would just duplicate the
> code.  How about I just document this more in a comment and keep it as
> `return false` (for instrumented tests on macOS)?
>
>
> https://reviews.llvm.org/D24699
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161129/c6a6040e/attachment.html>