[PATCH] D24699: [asan] Allow re-exec in instrumented unit tests on Darwin (fix unit tests on macOS <=10.10)

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 13:53:40 PST 2016


kubabrecka added a comment.

> If that's correct, then can we use the same trick as DyldNeedsEnvVariable for ReexecDisabled? Or am I making these two to be the same issue when they aren't?

Do you mean to check `dyldVersionNumber`?  That would just duplicate the code.  How about I just document this more in a comment and keep it as `return false` (for instrumented tests on macOS)?


https://reviews.llvm.org/D24699





More information about the llvm-commits mailing list