[PATCH] D24699: [asan] Allow re-exec in instrumented unit tests on Darwin (fix unit tests on macOS <=10.10)
Kuba (Brecka) Mracek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 29 16:48:00 PST 2016
kubabrecka added a comment.
> No need to duplicate if you export the function or make it online anyway.
I don't think we should publish DyldNeedsEnvVariable() as public interface of the sanitizer dylibs. And instrumented tests can't call non-public functions.
> But having the comment makes sense. I'm ok with this.
I'll just try to describe this better in a comment. Thanks!
https://reviews.llvm.org/D24699
More information about the llvm-commits
mailing list