[PATCH] D26401: [mips][ias] N32/N64 must not sort the relocation table.

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 11:07:09 PST 2016


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp:422
                                      std::vector<ELFRelocationEntry> &Relocs) {
+  if (hasRelocationAddend())
+    return;
----------------
I would add a comment here to describe why we do not need to sort relocation if `hasRelocationAddend()` return true.


Repository:
  rL LLVM

https://reviews.llvm.org/D26401





More information about the llvm-commits mailing list