[mischeduler]
Jonas Paulsson via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 8 07:57:18 PST 2016
Hi,
I see that the constructor of ScheduleDAGMI looks like:
public:
ScheduleDAGMI(MachineSchedContext *C,
std::unique_ptr<MachineSchedStrategy> S,
bool RemoveKillFlags)
These lines then seem wrong, in relation to the third argument:
static ScheduleDAGInstrs *createGenericSchedPostRA(MachineSchedContext *C) {
return new ScheduleDAGMI(C, make_unique<PostGenericScheduler>(C),
/*IsPostRA=*/true);
return new ScheduleDAGMI(C, make_unique<SystemZPostRASchedStrategy>(C),
/*IsPostRA=*/true);
The third argument tells ScheduleDAGInstrs to remove kill flags during
buildSchedGraph(), and is not the flag for post/pre-ra.
Ok to change comments per patch?
/Jonas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NewScheduleDAGMI.patch
Type: text/x-patch
Size: 1313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161108/a061f3aa/attachment.bin>
More information about the llvm-commits
mailing list