[mischeduler]

Andrew Trick via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 08:50:16 PST 2016


> On Nov 8, 2016, at 7:57 AM, Jonas Paulsson <paulsson at linux.vnet.ibm.com> wrote:
> 
> Hi,
> 
> I see that the constructor of ScheduleDAGMI looks like:
> 
> 
> public:
> 
>  ScheduleDAGMI(MachineSchedContext *C, std::unique_ptr<MachineSchedStrategy> S,
>                bool RemoveKillFlags)
> 
> 
> These lines then seem wrong, in relation to the third argument:
> 
> static ScheduleDAGInstrs *createGenericSchedPostRA(MachineSchedContext *C) {
>  return new ScheduleDAGMI(C, make_unique<PostGenericScheduler>(C), /*IsPostRA=*/true);
> 
> return new ScheduleDAGMI(C, make_unique<SystemZPostRASchedStrategy>(C),
>                         /*IsPostRA=*/true);
> 
> The third argument tells ScheduleDAGInstrs to remove kill flags during buildSchedGraph(), and is not the flag for post/pre-ra.
> 
> Ok to change comments per patch?
> 
> /Jonas
> 
> 
> <NewScheduleDAGMI.patch>

LGTM.
-Andy


More information about the llvm-commits mailing list