[PATCH] D23039: Kill deprecated attribute API

[Amaury SECHET via llvm-commits]

deadalnix added inline comments.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:1359
+static uint64_t getRawAttributeMask(Attribute::AttrKind Val) {
+  // FIXME: Remove this.
+  switch (Val) {
----------------
mehdi_amini wrote:
> Why? Can you elaborate the FIXME comment?
This code is just moved around. I did not write that comment.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:1431
+static void addRawAttributeValue(AttrBuilder &B, uint64_t Val) {
+  // FIXME: Remove this in 4.0.
+  if (!Val) return;
----------------
mehdi_amini wrote:
> This one should be removed, we're in 4.0 timeframe now and it won't be special.
Same here.


================
Comment at: lib/IR/Attributes.cpp:476
-uint64_t AttributeImpl::getAttrMask(Attribute::AttrKind Val) {
-  // FIXME: Remove this.
-  switch (Val) {
----------------
Comment used to be here.


================
Comment at: lib/IR/Attributes.cpp:1529
-AttrBuilder &AttrBuilder::addRawValue(uint64_t Val) {
-  // FIXME: Remove this in 4.0.
-  if (!Val) return *this;
----------------
dito


https://reviews.llvm.org/D23039