[PATCH] D23039: Kill deprecated attribute API

[Mehdi AMINI via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

OK! LGTM.



================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:1359
+static uint64_t getRawAttributeMask(Attribute::AttrKind Val) {
+  // FIXME: Remove this.
+  switch (Val) {
----------------
deadalnix wrote:
> mehdi_amini wrote:
> > Why? Can you elaborate the FIXME comment?
> This code is just moved around. I did not write that comment.
OK, but we don't really know why is this comment here, annoying...


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:1431
+static void addRawAttributeValue(AttrBuilder &B, uint64_t Val) {
+  // FIXME: Remove this in 4.0.
+  if (!Val) return;
----------------
deadalnix wrote:
> mehdi_amini wrote:
> > This one should be removed, we're in 4.0 timeframe now and it won't be special.
> Same here.
OK, still, remove this comment. 


https://reviews.llvm.org/D23039