[PATCH] D23039: Kill deprecated attribute API

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:1359
+static uint64_t getRawAttributeMask(Attribute::AttrKind Val) {
+  // FIXME: Remove this.
+  switch (Val) {
----------------
Why? Can you elaborate the FIXME comment?


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:1431
+static void addRawAttributeValue(AttrBuilder &B, uint64_t Val) {
+  // FIXME: Remove this in 4.0.
+  if (!Val) return;
----------------
This one should be removed, we're in 4.0 timeframe now and it won't be special.


https://reviews.llvm.org/D23039