[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.

[Vitaly Buka via llvm-commits]

I see. This is not on the patch again.
This arg is not obvious, called needs to make decision anyway.

Maybe just remove the arg, and make caller to lock the registry:

AddressDescription(uptr addr, uptr length) {
  asanThreadRegistry().CheckLocked();  // as first line, to fail soon.
  ...
}


On Fri, Sep 9, 2016 at 11:43 AM Filipe Cabecinhas <
filcab+llvm.phabricator at gmail.com> wrote:

> __asan_describe_address always needs the lock
> But the Error* descriptions have the lock already and you can't double
> lock.
>
>  Filipe
>
>
> On Friday, 9 September 2016, Vitaly Buka <vitalybuka at google.com> wrote:
>
> vitalybuka added inline comments.
>
> ================
> Comment at: lib/asan/asan_descriptions.h:197
> @@ +196,3 @@
> +  AddressDescription(uptr addr, uptr length,
> +                     bool shouldLockThreadRegistry = true) {
> +    if (GetShadowAddressInformation(addr, &data.shadow)) {
> ----------------
> And I'd prefer for now remove shouldLockThreadRegistry argument and do
> ThreadRegistryLock inside of GetStackAddressInformation uconditionally
>
>
> https://reviews.llvm.org/D24131
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160909/b2d55ecf/attachment.html>