[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.

[Filipe Cabecinhas via llvm-commits]

__asan_describe_address always needs the lock
But the Error* descriptions have the lock already and you can't double lock.

 Filipe

On Friday, 9 September 2016, Vitaly Buka <vitalybuka at google.com> wrote:

> vitalybuka added inline comments.
>
> ================
> Comment at: lib/asan/asan_descriptions.h:197
> @@ +196,3 @@
> +  AddressDescription(uptr addr, uptr length,
> +                     bool shouldLockThreadRegistry = true) {
> +    if (GetShadowAddressInformation(addr, &data.shadow)) {
> ----------------
> And I'd prefer for now remove shouldLockThreadRegistry argument and do
> ThreadRegistryLock inside of GetStackAddressInformation uconditionally
>
>
> https://reviews.llvm.org/D24131
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160909/228e3115/attachment.html>