<div dir="ltr">I see. This is not on the patch again.<div>This arg is not obvious, called needs to make decision anyway.</div><div><br></div><div>Maybe just remove the arg, and make caller to lock the registry:</div><div><br></div>AddressDescription(uptr addr, uptr length) { <br>  asanThreadRegistry().CheckLocked();  // as first line, to fail soon.<div>  ...</div><div>}<br><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 9, 2016 at 11:43 AM Filipe Cabecinhas <<a href="mailto:filcab%2Bllvm.phabricator@gmail.com">filcab+llvm.phabricator@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">__asan_describe_address always needs the lock<div class="gmail_msg">But the Error* descriptions have the lock already and you can't double lock.</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"></div><div class="gmail_msg"> Filipe</div><div class="gmail_msg"><span class="gmail_msg"></span><br class="gmail_msg"><br class="gmail_msg">On Friday, 9 September 2016, Vitaly Buka <<a href="mailto:vitalybuka@google.com" class="gmail_msg" target="_blank">vitalybuka@google.com</a>> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vitalybuka added inline comments.<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: lib/asan/asan_descriptions.h:197<br class="gmail_msg">
@@ +196,3 @@<br class="gmail_msg">
+  AddressDescription(uptr addr, uptr length,<br class="gmail_msg">
+                     bool shouldLockThreadRegistry = true) {<br class="gmail_msg">
+    if (GetShadowAddressInformation(addr, &data.shadow)) {<br class="gmail_msg">
----------------<br class="gmail_msg">
And I'd prefer for now remove shouldLockThreadRegistry argument and do ThreadRegistryLock inside of GetStackAddressInformation uconditionally<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D24131" class="gmail_msg" target="_blank">https://reviews.llvm.org/D24131</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div></blockquote></div>