__asan_describe_address always needs the lock<div>But the Error* descriptions have the lock already and you can't double lock.</div><div><br></div><div> Filipe<span></span><br><br>On Friday, 9 September 2016, Vitaly Buka <<a href="mailto:vitalybuka@google.com">vitalybuka@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vitalybuka added inline comments.<br>
<br>
================<br>
Comment at: lib/asan/asan_descriptions.h:<wbr>197<br>
@@ +196,3 @@<br>
+  AddressDescription(uptr addr, uptr length,<br>
+                     bool shouldLockThreadRegistry = true) {<br>
+    if (GetShadowAddressInformation(<wbr>addr, &data.shadow)) {<br>
----------------<br>
And I'd prefer for now remove shouldLockThreadRegistry argument and do ThreadRegistryLock inside of GetStackAddressInformation uconditionally<br>
<br>
<br>
<a href="https://reviews.llvm.org/D24131" target="_blank">https://reviews.llvm.org/<wbr>D24131</a><br>
<br>
<br>
<br>
</blockquote></div>