[PATCH] D22987: [lldb][cmake] Remove libclang as an lldbBase dependency (NFCI)

[Zachary Turner via llvm-commits]

Sorry I forgot about this. Lgtm
On Tue, Aug 2, 2016 at 4:03 PM Vedant Kumar <vsk at apple.com> wrote:

> vsk updated this revision to Diff 66584.
> vsk marked an inline comment as done.
> vsk added a comment.
>
> - Remove the foreach loop. It only caused a syntax error earlier because
> CLANG_USED_LIBS wasn't always defined.
>
>
> https://reviews.llvm.org/D22987
>
> Files:
>   CMakeLists.txt
>   cmake/modules/AddLLDB.cmake
>
> Index: cmake/modules/AddLLDB.cmake
> ===================================================================
> --- cmake/modules/AddLLDB.cmake
> +++ cmake/modules/AddLLDB.cmake
> @@ -84,10 +84,7 @@
>      endif()
>    endif()
>
> -  # Hack: only some LLDB libraries depend on the clang autogenerated
> headers,
> -  # but it is simple enough to make all of LLDB depend on some of those
> -  # headers without negatively impacting much of anything.
> -  add_dependencies(${name} libclang)
> +  add_dependencies(${name} ${CLANG_USED_LIBS})
>
>    set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")
>  endmacro(add_lldb_library)
> Index: CMakeLists.txt
> ===================================================================
> --- CMakeLists.txt
> +++ CMakeLists.txt
> @@ -1,5 +1,6 @@
>  cmake_minimum_required(VERSION 3.4.3)
>
> +include(cmake/LLDBDependencies.cmake)
>  include(cmake/modules/LLDBStandalone.cmake)
>  include(cmake/modules/LLDBConfig.cmake)
>  include(cmake/modules/AddLLDB.cmake)
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160818/efd1fbff/attachment.html>