[PATCH] D21916: Add LiveRegUnits class.

[Matthias Braun via llvm-commits]

MatzeB marked an inline comment as done.

================
Comment at: include/llvm/CodeGen/LiveRegUnits.h:95
@@ +94,3 @@
+  /// callee saved registers.
+  void addLiveOuts(const MachineBasicBlock &MBB);
+
----------------
qcolombet wrote:
> I am not sure I am happy adding the pristine register at this point. I understand why we need that, but my concern is that the name of does not convey (again without looking at the comments) that the pristine are added. Anyhow, that is consistent with LivePhysReg so fine, however, we should have a variant without the pristine.
> 
> Perhaps you wanted to add it only when we need it… and I can live with that.
> The bottom line is that you can ignore that comment :P.
Most users want the variant with the pristine registers (esp. the ones that do not know what pristine registers are), so I think it is warranted to use the simple name for this. Of course we should add the variant without pristine registers as soon as we need it.


Repository:
  rL LLVM

https://reviews.llvm.org/D21916