Sorry I forgot about this.  Lgtm<br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 2, 2016 at 4:03 PM Vedant Kumar <<a href="mailto:vsk@apple.com">vsk@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vsk updated this revision to Diff 66584.<br>
vsk marked an inline comment as done.<br>
vsk added a comment.<br>
<br>
- Remove the foreach loop. It only caused a syntax error earlier because CLANG_USED_LIBS wasn't always defined.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D22987" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22987</a><br>
<br>
Files:<br>
  CMakeLists.txt<br>
  cmake/modules/AddLLDB.cmake<br>
<br>
Index: cmake/modules/AddLLDB.cmake<br>
===================================================================<br>
--- cmake/modules/AddLLDB.cmake<br>
+++ cmake/modules/AddLLDB.cmake<br>
@@ -84,10 +84,7 @@<br>
     endif()<br>
   endif()<br>
<br>
-  # Hack: only some LLDB libraries depend on the clang autogenerated headers,<br>
-  # but it is simple enough to make all of LLDB depend on some of those<br>
-  # headers without negatively impacting much of anything.<br>
-  add_dependencies(${name} libclang)<br>
+  add_dependencies(${name} ${CLANG_USED_LIBS})<br>
<br>
   set_target_properties(${name} PROPERTIES FOLDER "lldb libraries")<br>
 endmacro(add_lldb_library)<br>
Index: CMakeLists.txt<br>
===================================================================<br>
--- CMakeLists.txt<br>
+++ CMakeLists.txt<br>
@@ -1,5 +1,6 @@<br>
 cmake_minimum_required(VERSION 3.4.3)<br>
<br>
+include(cmake/LLDBDependencies.cmake)<br>
 include(cmake/modules/LLDBStandalone.cmake)<br>
 include(cmake/modules/LLDBConfig.cmake)<br>
 include(cmake/modules/AddLLDB.cmake)<br>
<br>
<br>
</blockquote></div>