[PATCH] D23282: [IR/GlobalISel] move compare predicates into lib/Support

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 17 09:45:41 PDT 2016


On 16 August 2016 at 14:10, Chandler Carruth <chandlerc at gmail.com> wrote:
> FWIW, I agree. If you are relying on a perfect 1:1 matching of the IR predicates to the MI predicates, I don't see much benefit in shifting the header to support. I see some small benefit, but it isn't clear to me that it is worth it...

Fair enough, I'll rework my comparisons on top of CmpInst. Thanks for
the comments both of you!

Tim.


More information about the llvm-commits mailing list