[PATCH] D23282: [IR/GlobalISel] move compare predicates into lib/Support

[Chandler Carruth via llvm-commits]

chandlerc added a subscriber: chandlerc.
chandlerc added a comment.

In https://reviews.llvm.org/D23282#517014, @mehdi_amini wrote:

> I don't make sense of hosting these definitions in libSupport.
>
> I think you are creating actually a dependency from GlobalISel to the IR as soon as you want a one-to-one mapping like that and reuse the list.
>  Just moving it in a separate library just for the purpose of not including llvm/IR/ seems like very artificial to me, and "breaks" the dependency on the surface.


FWIW, I agree. If you are relying on a perfect 1:1 matching of the IR predicates to the MI predicates, I don't see much benefit in shifting the header to support. I see some small benefit, but it isn't clear to me that it is worth it...


Repository:
  rL LLVM

https://reviews.llvm.org/D23282