[PATCH] D23282: [IR/GlobalISel] move compare predicates into lib/Support

[Mehdi Amini via llvm-commits]

> On Aug 17, 2016, at 9:45 AM, Tim Northover <t.p.northover at gmail.com> wrote:
> 
> On 16 August 2016 at 14:10, Chandler Carruth <chandlerc at gmail.com> wrote:
>> FWIW, I agree. If you are relying on a perfect 1:1 matching of the IR predicates to the MI predicates, I don't see much benefit in shifting the header to support. I see some small benefit, but it isn't clear to me that it is worth it...
> 
> Fair enough, I'll rework my comparisons on top of CmpInst. Thanks for
> the comments both of you!

I’d be fine with refactoring the predicates out of CmpInst to avoid refering to the inst, I’m less inclined to see this live in lib/Support though.

— 
Mehdi