[PATCH] D23501: Correct the upper bound for a CBZ/CBNZ branch target.
Oliver Stannard via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 15 07:35:40 PDT 2016
olista01 added inline comments.
================
Comment at: test/MC/ARM/thumb-cb-negative-offsets.s:23
@@ +22,3 @@
+ cbz r0, label2
+ cbnz r0, label2
+ .space 128
----------------
The label is in-range of this instruction.
================
Comment at: test/MC/ARM/thumb-cb-negative-offsets.s:26
@@ +25,2 @@
+label2:
+ .word 4
----------------
This should probably be a nop, since we are branching to it. I'd suggest making this two nops, with a label for each, so that you can test the exact bound on the offset for both instructions.
https://reviews.llvm.org/D23501
More information about the llvm-commits
mailing list