[PATCH] D23501: Correct the upper bound for a CBZ/CBNZ branch target.

[Prakhar Bahuguna via llvm-commits]

prakhar updated this revision to Diff 68035.
prakhar added a comment.

Use the offset bounds before 4-byte correction


https://reviews.llvm.org/D23501

Files:
  lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
  test/MC/ARM/thumb-cb-negative-offsets.s

Index: test/MC/ARM/thumb-cb-negative-offsets.s
===================================================================
--- test/MC/ARM/thumb-cb-negative-offsets.s
+++ test/MC/ARM/thumb-cb-negative-offsets.s
@@ -17,3 +17,10 @@
   .space 1000
 label1:
   .word 4
+
+@ CHECK: out of range pc-relative fixup value
+  cbz r0, label2
+  cbnz r0, label2
+  .space 128
+label2:
+  .word 4
Index: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
===================================================================
--- lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
+++ lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
@@ -578,8 +578,10 @@
     // Offset by 4, and don't encode the low two bits.
     return ((Value - 4) >> 2) & 0xff;
   case ARM::fixup_arm_thumb_cb: {
-    // CB instructions can only branch to offsets in [0, 126] in multiples of 2
-    if (Ctx && ((int64_t)Value < 0 || Value > 0x3e || Value & 1)) {
+    // CB instructions can only branch to offsets in [4, 126] in multiples of 2
+    // so ensure that the raw value LSB is zero and it lies in [2, 130].
+    // An offset of 2 will be relaxed to a NOP.
+    if (Ctx && ((int64_t)Value < 2 || Value > 0x82 || Value & 1)) {
       Ctx->reportError(Fixup.getLoc(), "out of range pc-relative fixup value");
       return 0;
     }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23501.68035.patch
Type: text/x-patch
Size: 1277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160815/0f6e5582/attachment.bin>