[PATCH] D23501: Correct the upper bound for a CBZ/CBNZ branch target.

[Prakhar Bahuguna via llvm-commits]

prakhar added inline comments.

================
Comment at: test/MC/ARM/thumb-cb-negative-offsets.s:23
@@ +22,3 @@
+  cbz r0, label2
+  cbnz r0, label2
+  .space 128
----------------
olista01 wrote:
> The label is in-range of this instruction.
Yes, that is deliberate to test that this will not cause an error unlike the preceding instruction.

================
Comment at: test/MC/ARM/thumb-cb-negative-offsets.s:26
@@ +25,2 @@
+label2:
+  .word 4
----------------
olista01 wrote:
> This should probably be a nop, since we are branching to it. I'd suggest making this two nops, with a label for each, so that you can test the exact bound on the offset for both instructions.
Okay.


https://reviews.llvm.org/D23501