[llvm] r276677 - MachineVerifier: Fix printing nonsense for physical registers

[Quentin Colombet via llvm-commits]

Yes, as a clean-up, but for the patch at stake, the places where we change reg to regunit.

> On Aug 12, 2016, at 7:50 PM, Matthias Braun <mbraun at apple.com> wrote:
> 
> And the "reg" field of LiveInterval and a lot of other places everywhere...
> 
>> On Aug 12, 2016, at 7:49 PM, Matthias Braun <mbraun at apple.com <mailto:mbraun at apple.com>> wrote:
>> 
>> The one of verifyLiveRange()? Yes.
>> 
>>> On Aug 12, 2016, at 7:48 PM, Quentin Colombet via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>>> 
>>> Okay, then the argument name is miss leading.
>>> It should be VRegOrRegUnit like the other places.
>>> 
>>>> On Aug 12, 2016, at 6:50 PM, Matthias Braun <mbraun at apple.com <mailto:mbraun at apple.com>> wrote:
>>>> 
>>>> Looks correct to me. LiveIntervals are about regunits or vregs it is a common error to accidentally print them as physregs or vregs.
>>>> 
>>>> - Matthias
>>>> 
>>>>> On Aug 12, 2016, at 6:44 PM, Quentin Colombet via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>>>>> 
>>>>> Hi Matt,
>>>>> 
>>>>> Sorry for the late notice, but unless I miss something, this commit does not make sense to me.
>>>>> I could have understood that we want to use report_context_vreg, but report_context_vreg_regunit in that context seems wrong to me.
>>>>> 
>>>>> Thanks,
>>>>> -Quentin
>>>>>> On Jul 25, 2016, at 12:39 PM, Matt Arsenault via llvm-commits <llv
m-commits at lists.llvm.org <mailto:m-commits at lists.llvm.org>> wrote:
>>>>>> 
>>>>>> Author: arsenm
>>>>>> Date: Mon Jul 25 14:39:01 2016
>>>>>> New Revision: 276677
>>>>>> 
>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=276677&view=rev <http://llvm.org/viewvc/llvm-project?rev=276677&view=rev>
>>>>>> Log:
>>>>>> MachineVerifier: Fix printing nonsense for physical registers
>>>>>> 
>>>>>> Modified:
>>>>>>    llvm/trunk/lib/CodeGen/MachineVerifier.cpp
>>>>>> 
>>>>>> Modified: llvm/trunk/lib/CodeGen/MachineVerifier.cpp
>>>>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineVerifier.cpp?rev=276677&r1=276676&r2=276677&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineVerifier.cpp?rev=276677&r1=276676&r2=276677&view=diff>
>>>>>> ==============================================================================
>>>>>> --- llvm/trunk/lib/CodeGen/MachineVerifier.cpp (original)
>>>>>> +++ llvm/trunk/lib/CodeGen/MachineVerifier.cpp Mon Jul 25 14:39:01 2016
>>>>>> @@ -213,7 +213,7 @@ namespace {
>>>>>>     void report(const char *msg, const MachineOperand *MO, unsigned MONum);
>>>>>> 
>>>>>>     void report_context(const LiveInterval &LI) const;
>>>>>> -    void report_context(const LiveRange &LR, unsigned Reg,
>>>>>> +    void report_context(const LiveRange &LR, unsigned VRegUnit,
>>>>>>                         LaneBitmask LaneMask) const;
>>>>>>     void report_context(const LiveRange::Segment &S) const;
>>>>>>     void report_context(const VNInfo &VNI) const;
>>>>>> @@ -474,10 +474,10 @@ void MachineVerifier::report_context(con
>>>>>>   errs() << "- interval:    " << LI << '\n';
>>>>>> }
>>>>>> 
>>>>>> -void MachineVerifier::report_context(const LiveRange &LR, unsigned Reg,
>>>>>> +void MachineVerifier::report_context(const LiveRange &LR, unsigned VRegUnit,
>>>>>>                                      LaneBitmask LaneMask) const {
>>>>>>   report_context_liverange(LR);
>>>>>> -  errs() << "- register:    " << PrintReg(Reg, TRI) << '\n';
>>>>>> +  report_context_vreg_regunit(VRegUnit);
>>>>>>   if (LaneMask != 0)
>>>>>>     report_context_lanemask(LaneMask);
>>>>>> }
>>>>>> 
>>>>>> 
>>>>>> _______________________________________________
>>>>>> llvm-commits mailing list
>>>>>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>>>>> 
>>>>> _______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160812/6d5f510a/attachment.html>