[llvm] r276723 - GlobalISel: remove redundant ';'s. NFC

[Quentin Colombet via llvm-commits]

Hi Tim,

Any particular reasons for removing them?

Although they are useless, I like to have them for consistency. I mean I expect a C/C++ statement to end with a ‘;’ and I don’t like to rely on the actual expansion of a macro to do the right thing.

That being said, I don’t know what is the standard for LLVM, so if that’s what we do elsewhere, so be it :).

Thanks,
-Quentin
> On Jul 25, 2016, at 8:29 PM, Tim Northover via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: tnorthover
> Date: Mon Jul 25 22:29:18 2016
> New Revision: 276723
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=276723&view=rev
> Log:
> GlobalISel: remove redundant ';'s. NFC
> 
> Modified:
>    llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp
>    llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizePass.cpp
>    llvm/trunk/lib/CodeGen/GlobalISel/RegBankSelect.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp?rev=276723&r1=276722&r2=276723&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp (original)
> +++ llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp Mon Jul 25 22:29:18 2016
> @@ -29,7 +29,7 @@ using namespace llvm;
> 
> char IRTranslator::ID = 0;
> INITIALIZE_PASS(IRTranslator, "irtranslator", "IRTranslator LLVM IR -> MI",
> -                false, false);
> +                false, false)
> 
> IRTranslator::IRTranslator() : MachineFunctionPass(ID), MRI(nullptr) {
>   initializeIRTranslatorPass(*PassRegistry::getPassRegistry());
> 
> Modified: llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizePass.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizePass.cpp?rev=276723&r1=276722&r2=276723&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizePass.cpp (original)
> +++ llvm/trunk/lib/CodeGen/GlobalISel/MachineLegalizePass.cpp Mon Jul 25 22:29:18 2016
> @@ -27,7 +27,7 @@ using namespace llvm;
> char MachineLegalizePass::ID = 0;
> INITIALIZE_PASS(MachineLegalizePass, DEBUG_TYPE,
>                 "Legalize the Machine IR a function's Machine IR", false,
> -                false);
> +                false)
> 
> MachineLegalizePass::MachineLegalizePass() : MachineFunctionPass(ID) {
>   initializeMachineLegalizePassPass(*PassRegistry::getPassRegistry());
> 
> Modified: llvm/trunk/lib/CodeGen/GlobalISel/RegBankSelect.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/RegBankSelect.cpp?rev=276723&r1=276722&r2=276723&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/GlobalISel/RegBankSelect.cpp (original)
> +++ llvm/trunk/lib/CodeGen/GlobalISel/RegBankSelect.cpp Mon Jul 25 22:29:18 2016
> @@ -42,7 +42,7 @@ INITIALIZE_PASS_DEPENDENCY(MachineBlockF
> INITIALIZE_PASS_DEPENDENCY(MachineBranchProbabilityInfo)
> INITIALIZE_PASS_END(RegBankSelect, "regbankselect",
>                     "Assign register bank of generic virtual registers", false,
> -                    false);
> +                    false)
> 
> RegBankSelect::RegBankSelect(Mode RunningMode)
>     : MachineFunctionPass(ID), RBI(nullptr), MRI(nullptr), TRI(nullptr),
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits