<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Yes, as a clean-up, but for the patch at stake, the places where we change reg to regunit.<div class=""><br class=""><div class=""><div class=""><div><blockquote type="cite" class=""><div class="">On Aug 12, 2016, at 7:50 PM, Matthias Braun <<a href="mailto:mbraun@apple.com" class="">mbraun@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">And the "reg" field of LiveInterval and a lot of other places everywhere...</div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 12, 2016, at 7:49 PM, Matthias Braun <<a href="mailto:mbraun@apple.com" class="">mbraun@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">The one of verifyLiveRange()? Yes.</div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 12, 2016, at 7:48 PM, Quentin Colombet via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Okay, then the argument name is miss leading.<div class="">It should be VRegOrRegUnit like the other places.</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 12, 2016, at 6:50 PM, Matthias Braun <<a href="mailto:mbraun@apple.com" class="">mbraun@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Looks correct to me. LiveIntervals are about regunits or vregs it is a common error to accidentally print them as physregs or vregs.</div><div class=""><br class=""></div><div class="">- Matthias</div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 12, 2016, at 6:44 PM, Quentin Colombet via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Matt,<div class=""><br class=""></div><div class="">Sorry for the late notice, but unless I miss something, this commit does not make sense to me.</div><div class="">I could have understood that we want to use <span style="font-family: Menlo; font-size: 11px;" class="">report_context_vreg</span>, but <span style="font-family: Menlo; font-size: 11px;" class="">report_context_vreg_regunit</span> in that context seems wrong to me.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">-Quentin<br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jul 25, 2016, at 12:39 PM, Matt Arsenault via llvm-commits <llv<a href="mailto:m-commits@lists.llvm.org" class="">m-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: arsenm<br class="">Date: Mon Jul 25 14:39:01 2016<br class="">New Revision: 276677<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=276677&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=276677&view=rev</a><br class="">Log:<br class="">MachineVerifier: Fix printing nonsense for physical registers<br class=""><br class="">Modified:<br class=""> llvm/trunk/lib/CodeGen/MachineVerifier.cpp<br class=""><br class="">Modified: llvm/trunk/lib/CodeGen/MachineVerifier.cpp<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineVerifier.cpp?rev=276677&r1=276676&r2=276677&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineVerifier.cpp?rev=276677&r1=276676&r2=276677&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/lib/CodeGen/MachineVerifier.cpp (original)<br class="">+++ llvm/trunk/lib/CodeGen/MachineVerifier.cpp Mon Jul 25 14:39:01 2016<br class="">@@ -213,7 +213,7 @@ namespace {<br class=""> void report(const char *msg, const MachineOperand *MO, unsigned MONum);<br class=""><br class=""> void report_context(const LiveInterval &LI) const;<br class="">- void report_context(const LiveRange &LR, unsigned Reg,<br class="">+ void report_context(const LiveRange &LR, unsigned VRegUnit,<br class=""> LaneBitmask LaneMask) const;<br class=""> void report_context(const LiveRange::Segment &S) const;<br class=""> void report_context(const VNInfo &VNI) const;<br class="">@@ -474,10 +474,10 @@ void MachineVerifier::report_context(con<br class=""> errs() << "- interval: " << LI << '\n';<br class=""> }<br class=""><br class="">-void MachineVerifier::report_context(const LiveRange &LR, unsigned Reg,<br class="">+void MachineVerifier::report_context(const LiveRange &LR, unsigned VRegUnit,<br class=""> LaneBitmask LaneMask) const {<br class=""> report_context_liverange(LR);<br class="">- errs() << "- register: " << PrintReg(Reg, TRI) << '\n';<br class="">+ report_context_vreg_regunit(VRegUnit);<br class=""> if (LaneMask != 0)<br class=""> report_context_lanemask(LaneMask);<br class=""> }<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></div></body></html>