[PATCH] D16829: An implementation of Swing Modulo Scheduling

[Brendon Cahoon via llvm-commits]

bcahoon added inline comments.

================
Comment at: lib/CodeGen/MachinePipeliner.cpp:2222
@@ +2221,3 @@
+  generatePhis(KernelBB, PrologBBs.back(), KernelBB, KernelBB, Schedule, VRMap,
+               InstrMap, MaxStageCount, MaxStageCount, false);
+
----------------
sebpop wrote:
> Both generateExistingPhis and generatePhis are passed the same parameters.  Can we have this code factored up in a class: that would allow to split these two functions into smaller functions easier to follow.
Hi Sebastian - thanks for the comments. The code for generating Phis in the pipelined schedule really could use some work. It's a non-trivial effort though.  I'll try to do some refactoring to improve it though.


http://reviews.llvm.org/D16829