[llvm] r268969 - [PGO] Fix __llvm_profile_raw_version linkage in MACHO

[Rong Xu via llvm-commits]

On Tue, May 10, 2016 at 1:31 AM, Renato Golin <renato.golin at linaro.org>
wrote:

> On 9 May 2016 at 22:03, Rong Xu via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: xur
> > Date: Mon May  9 16:03:06 2016
> > New Revision: 268969
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=268969&view=rev
> > Log:
> > [PGO] Fix __llvm_profile_raw_version linkage in MACHO
> > IR instrumentation generates a COMDAT symbol __llvm_profile_raw_version
> to
> > overwrite the same symbol in profile run-time to distinguish IR profiles
> from
> > Clang generated profiles. In MACHO, LinkOnceODR linkage is used due to
> the
> > lack of COMDAT support.
>
> Hi Rong,
>
> After multiple attempts, you couldn't fix the test, so I just reverted
> all three changes.
>
> Please read the docs on how to make target specific tests:
>
> http://llvm.org/docs/TestingGuide.html#platform-specific-tests


Thanks for taking care of buildbot failures.

The link you provided is really useful. I've changed the patch and
resubmitted as r269090.
Thanks a lot!

-Rong


>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160510/ce267093/attachment.html>