[PATCH] D20082: [ProfileData] Use SoftInstrProfErrors to count soft errors

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 14:06:20 PDT 2016


vsk created this revision.
vsk added a reviewer: davidxl.
vsk added subscribers: lhames, llvm-commits.

This helper class will make the transition to Error/Expected easier.

The immediate benefit is that it keeps track of the number of soft errors encountered, which can help during debugging. The future benefit is that `SoftInstrProfErrors` can be made undroppable by adding a simple destructor: this lets us handle soft errors properly with a significantly reduced malloc overhead.

Another benefit is that it lets us delete some error-tracking code in the main "merge" and "scale" logic.

http://reviews.llvm.org/D20082

Files:
  include/llvm/ProfileData/InstrProf.h
  lib/ProfileData/InstrProf.cpp
  lib/ProfileData/InstrProfWriter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20082.56625.patch
Type: text/x-patch
Size: 11303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160509/ecf3d880/attachment.bin>


More information about the llvm-commits mailing list