[llvm] r268969 - [PGO] Fix __llvm_profile_raw_version linkage in MACHO

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 01:31:22 PDT 2016


On 9 May 2016 at 22:03, Rong Xu via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: xur
> Date: Mon May  9 16:03:06 2016
> New Revision: 268969
>
> URL: http://llvm.org/viewvc/llvm-project?rev=268969&view=rev
> Log:
> [PGO] Fix __llvm_profile_raw_version linkage in MACHO
> IR instrumentation generates a COMDAT symbol __llvm_profile_raw_version to
> overwrite the same symbol in profile run-time to distinguish IR profiles from
> Clang generated profiles. In MACHO, LinkOnceODR linkage is used due to the
> lack of COMDAT support.

Hi Rong,

After multiple attempts, you couldn't fix the test, so I just reverted
all three changes.

Please read the docs on how to make target specific tests:

http://llvm.org/docs/TestingGuide.html#platform-specific-tests

cheers,
--renato


More information about the llvm-commits mailing list